Skip to content

refactor: shuffle code around #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2025
Merged

refactor: shuffle code around #258

merged 1 commit into from
Jan 15, 2025

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Jan 15, 2025 •
edited
Loading

  • Move utils to the utils folder to keep the main files (build/bundle) small and focused
  • rename index.ts -> build.ts, I see no point in having index.ts and they make code navigation harder. If we should have index.ts I think they should only re-export not contain any other code.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jan 15, 2025 •
edited
Loading

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@258

commit: d1623d8

@vicb vicb requested review from dario-piotrowicz and james-elicx and removed request for dario-piotrowicz January 15, 2025 13:46
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 15, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: d1623d8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vicb vicb force-pushed the shuffle branch 3 times, most recently from 9004a4e to d1623d8 Compare January 15, 2025 14:02
@dario-piotrowicz
Copy link
Contributor

rename index.ts -> build.ts, I see no point in having index.ts and they make code navigation harder. If we should have index.ts I think they should only re-export not contain any other code.

Regarding index.ts files in general I was the one advocating for those as I think that they generally make the code cleaner, however after the changes in #192 and the bundle resolution removal I don't really think that they make the code any cleaner at all (actually the oppositve), so I'm actually in favour of not using index.ts anymore at all if you want 🙂

@vicb
Copy link
Contributor Author

vicb commented Jan 15, 2025

Thanks for the review!

so I'm actually in favour of not using index.ts anymore at all if you want

I don't mind if they only re-export. (The thing that I want is to go to build.ts to see the build related code and not having to pick amongst 5 different index.ts)

@vicb vicb merged commit e6078b5 into main Jan 15, 2025
7 checks passed
@vicb vicb deleted the shuffle branch January 15, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dario-piotrowicz dario-piotrowicz dario-piotrowicz approved these changes

@james-elicx james-elicx Awaiting requested review from james-elicx

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vicb @dario-piotrowicz